Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftover code from 04-channel handshake crossing hellos #1778

Closed
3 tasks
colin-axner opened this issue Jul 26, 2022 · 1 comment · Fixed by #1792
Closed
3 tasks

Remove leftover code from 04-channel handshake crossing hellos #1778

colin-axner opened this issue Jul 26, 2022 · 1 comment · Fixed by #1792
Assignees
@colin-axner
Labels
04-channel good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v4.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Crossing hello's is no longer possible with 04-channel. Previous Channel ID is deprecated in MsgChanOpenTry. Replace this check with an assertion that the previous channel id is empty

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces labels Jul 26, 2022
@crodriguezvega crodriguezvega added this to the v4.0.0 milestone Jul 26, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jul 26, 2022
@colin-axner colin-axner self-assigned this Jul 27, 2022
@colin-axner
Copy link
Contributor Author

will remove the argument from NewMsgChannelOpenTry as well

@colin-axner colin-axner mentioned this issue Jul 27, 2022
Merged
9 tasks
Repository owner moved this from Todo to Done in ibc-go Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
04-channel good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

fix: assert previous channel identifer is empty in Msg ValidateBasic cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner