Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sdk.Msg interface for channel upgrade handshake messages #1622

Closed
4 of 7 tasks
Tracked by #1617
damiannolan opened this issue Jun 29, 2022 · 2 comments
Closed
4 of 7 tasks
Tracked by #1617

Implement sdk.Msg interface for channel upgrade handshake messages #1622

damiannolan opened this issue Jun 29, 2022 · 2 comments
Assignees
@chatton @charleenfei
Labels
04-channel
Milestone
04-channel upgrad...

Comments

@damiannolan
Copy link
Member

damiannolan commented Jun 29, 2022 •
edited
Loading

Summary

Implement the sdk.Msg interface for the 04-channel upgrade handshake messages.
Add the sdk.Msg methods to the 04-channel msgs.go file.

  • MsgChannelUpgradeInit (@charleenfei)
    • ValidateBasic
    • GetSigners
  • MsgChannelUpgradeTry (@charleenfei)
    • ValidateBasic
    • GetSigners
  • MsgChannelUpgradeAck (@charleenfei)
    • ValidateBasic
    • GetSigners
  • MsgChannelUpgradeConfirm (@chatton)
    • ValidateBasic
    • GetSigners

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Jun 29, 2022
@damiannolan damiannolan self-assigned this Jun 29, 2022
This was referenced Jun 29, 2022
Closed
Closed
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jun 29, 2022
@damiannolan damiannolan moved this from Backlog to Todo in ibc-go Jul 21, 2022
@damiannolan
Copy link
Member Author

damiannolan commented Jul 25, 2022 •
edited
Loading

Preferably split the work into 4 PRs, one per message type. Please comment which message type you are working on before picking up the work! :)

@charleenfei charleenfei moved this from Todo to In progress in ibc-go Jul 28, 2022
@chatton
Copy link
Contributor

chatton commented Jul 29, 2022

I will pick up MsgChannelUpgradeConfirm

@chatton chatton self-assigned this Jul 29, 2022
@chatton chatton mentioned this issue Jul 29, 2022
Merged
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Aug 1, 2022
This was referenced Aug 2, 2022
Merged
Merged
Merged
Repository owner moved this from In review to Done in ibc-go Aug 6, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

@charleenfei charleenfei

Labels
04-channel
Projects
ibc-go
Status: Done 🥳
Milestone
04-channel upgrades alpha
Development

No branches or pull requests
3 participants
@damiannolan @chatton @charleenfei