Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upgrade states to 04-channel State enum proto #1604

Closed
3 tasks
damiannolan opened this issue Jun 29, 2022 · 1 comment · Fixed by #1789
Closed
3 tasks

Add upgrade states to 04-channel State enum proto #1604

damiannolan opened this issue Jun 29, 2022 · 1 comment · Fixed by #1789
Assignees
@chatton
Labels
04-channel
Milestone
04-channel upgrad...

Comments

@damiannolan
Copy link
Member

Summary

The channel State enum should be extended to include the new upgrade state values.

Add the following values to the channel State enum protobuf definition:

  • STATE_UPGRADE_INIT
  • STATE_UPGRADE_TRY

The chain that is proposing the upgrade should set the channel state from OPEN to UPGRADE_INIT.
The counterparty chain that accepts the upgrade should set the channel state from OPEN to UPGRADE_TRY

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Jun 29, 2022
@damiannolan damiannolan changed the title Add upgrade states to channel State enum proto Add upgrade states to 04-channel State enum proto Jun 29, 2022
@damiannolan damiannolan mentioned this issue Jun 29, 2022
Closed
10 tasks
@damiannolan damiannolan self-assigned this Jun 29, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jun 29, 2022
@damiannolan damiannolan moved this from Backlog to Todo in ibc-go Jul 21, 2022
@chatton chatton assigned chatton and unassigned damiannolan Jul 27, 2022
@chatton chatton mentioned this issue Jul 27, 2022
Merged
9 tasks
@chatton chatton linked a pull request Jul 27, 2022 that will close this issue
chore: adding upgrade states to channel state enum #1789
Merged
9 tasks
@chatton
Copy link
Contributor

chatton commented Jul 28, 2022

closed by #1789

@chatton chatton closed this as completed Jul 28, 2022
Repository owner moved this from Todo to Done in ibc-go Jul 28, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
04-channel
Projects
ibc-go
Status: Done 🥳
Milestone
04-channel upgrades alpha
Development

Successfully merging a pull request may close this issue.

chore: adding upgrade states to channel state enum cosmos/ibc-go
2 participants
@damiannolan @chatton