Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpgradeTimeoutPath to 24-host #1603

Closed
3 tasks
damiannolan opened this issue Jun 29, 2022 · 3 comments
Closed
3 tasks

Add UpgradeTimeoutPath to 24-host #1603

damiannolan opened this issue Jun 29, 2022 · 3 comments

Comments

@damiannolan
Copy link
Member

Summary

The timeout path is a public path set by the upgrade initiator to determine when the TRY step should timeout. It stores the timeoutHeight and timeoutTimestamp by which point the counterparty must have progressed to the TRY step. The TRY step will prove the timeout values set by the initiating chain and ensure the timeout has not passed. Or in the case of a timeout, in which case counterparty proves that the timeout has passed on its chain and restores the channel.

Add UpgradeTimeoutPath to 24-host with associated key func.

  • UpgradeTimeoutPath
  • UpgradeTimeoutKey

Ref: 24-host/keys.go

function timeoutPath(portIdentifier: Identifier, channelIdentifier: Identifier) Path {
    return "channelUpgrade/ports/{portIdentifier}/channelIdentifier/{channelIdentifier}/upgradeTimeout"
}

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Jun 29, 2022
@damiannolan damiannolan mentioned this issue Jun 29, 2022
10 tasks
@damiannolan damiannolan self-assigned this Jun 29, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jun 29, 2022
@damiannolan damiannolan moved this from Backlog to Todo in ibc-go Jul 21, 2022
@damiannolan
Copy link
Member Author

Review spec for any updates to key paths

@chatton chatton assigned chatton and unassigned damiannolan Jul 27, 2022
@chatton
Copy link
Contributor

chatton commented Jul 28, 2022

The spec has been updated with

function channelUpgradeTimeoutPath(portIdentifier: Identifier, channelIdentifier: Identifier) Path {
    return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeTimeout"
}

@chatton
Copy link
Contributor

chatton commented Jul 28, 2022

closed by #1821

@chatton chatton closed this as completed Jul 28, 2022
Repository owner moved this from Todo to Done in ibc-go Jul 28, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

No branches or pull requests

2 participants