Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpgradeErrorPath to 24-host #1602

Closed
3 tasks
damiannolan opened this issue Jun 29, 2022 · 1 comment · Fixed by #1822
Closed
3 tasks

Add UpgradeErrorPath to 24-host #1602

damiannolan opened this issue Jun 29, 2022 · 1 comment · Fixed by #1822

Comments

@damiannolan
Copy link
Member

Summary

The upgrade error path is a public path that can signal an error of the upgrade to the counterparty for the given upgrade attempt. It does not store anything in the successful case, but it will store the ErrorReceipt in the case that a chain does not accept the proposed upgrade.

Add UpgradeErrorPath to 24-host with associated key func.

  • UpgradeErrorPath
  • UpgradeErrorKey

Ref: 24-host/keys.go

function errorPath(portIdentifier: Identifier, channelIdentifier: Identifier): Path {
    return "channelUpgrade/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeError"
}

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Jun 29, 2022
@damiannolan damiannolan mentioned this issue Jun 29, 2022
10 tasks
@damiannolan damiannolan self-assigned this Jun 29, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jun 29, 2022
@damiannolan damiannolan moved this from Backlog to Todo in ibc-go Jul 21, 2022
@damiannolan
Copy link
Member Author

Review spec for any updates to key paths

@charleenfei charleenfei moved this from Todo to In progress in ibc-go Jul 28, 2022
Repository owner moved this from In progress to Done in ibc-go Jul 28, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

2 participants