Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit channel version during OpenInit/OpenTry handshake steps #1203

Closed
3 tasks
colin-axner opened this issue Mar 30, 2022 · 3 comments
Closed
3 tasks

Emit channel version during OpenInit/OpenTry handshake steps #1203

colin-axner opened this issue Mar 30, 2022 · 3 comments

Comments

@colin-axner
Copy link
Contributor

Summary

Channel versions are not emitted despite being selected by an IBC application stack.

Problem Definition

During OpenTry, the channel version is decided by the IBC application stack. The version selected by the counterparty in OpenInit might be completely different from the version selected during the OpenTry step. This information should be emitted in events. The same functionality will eventually be applied to OpenInit and thus the version should be emitted for that handshake step as well.

Proposal

Emit the channel version selected by an IBC application stack after OpenInit and OpenTry.

These changes can be backported on one condition:

  • no public variables are added to backports (preventing go API from expanding requiring a minor release)

so do changes as normal to main (we can tag for minor backport). When the backports are applied to existing releases, we must modify the code to replace public variable calls with the hardcoded string, we should probably add a comment to indicate this was done to prevent the go API from increasing for a patch release


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

I see that we also don't include the connection version when emitting an even after ConnectionOpenInit and ConnectionOpenTry. Should we also do it, or it's not necessary because at the moment we just use the DefaultIBCVersion?

@colin-axner
Copy link
Contributor Author

Not currently necessary, but wouldn't hurt to do

@crodriguezvega
Copy link
Contributor

Closed by #1279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants