You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Channel versions are not emitted despite being selected by an IBC application stack.
Problem Definition
During OpenTry, the channel version is decided by the IBC application stack. The version selected by the counterparty in OpenInit might be completely different from the version selected during the OpenTry step. This information should be emitted in events. The same functionality will eventually be applied to OpenInit and thus the version should be emitted for that handshake step as well.
Proposal
Emit the channel version selected by an IBC application stack after OpenInit and OpenTry.
These changes can be backported on one condition:
no public variables are added to backports (preventing go API from expanding requiring a minor release)
so do changes as normal to main (we can tag for minor backport). When the backports are applied to existing releases, we must modify the code to replace public variable calls with the hardcoded string, we should probably add a comment to indicate this was done to prevent the go API from increasing for a patch release
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
I see that we also don't include the connection version when emitting an even after ConnectionOpenInit and ConnectionOpenTry. Should we also do it, or it's not necessary because at the moment we just use the DefaultIBCVersion?
Summary
Channel versions are not emitted despite being selected by an IBC application stack.
Problem Definition
During OpenTry, the channel version is decided by the IBC application stack. The version selected by the counterparty in OpenInit might be completely different from the version selected during the OpenTry step. This information should be emitted in events. The same functionality will eventually be applied to OpenInit and thus the version should be emitted for that handshake step as well.
Proposal
Emit the channel version selected by an IBC application stack after OpenInit and OpenTry.
These changes can be backported on one condition:
so do changes as normal to main (we can tag for minor backport). When the backports are applied to existing releases, we must modify the code to replace public variable calls with the hardcoded string, we should probably add a comment to indicate this was done to prevent the go API from increasing for a patch release
For Admin Use
The text was updated successfully, but these errors were encountered: