Inconsistent setting of genesis supply

[colin-axner]

Summary of Bug

The testnet command creates a staking token and a token corresponding to the directory name, but it doesn't update the genesis total supply. Previous versions of the SDK didn't do total supply validation of the value in the genesis file. Since the newer versions do, using this command doesn't function properly as the genesis generated is invalid

Version

master branch

Steps to Reproduce

Use the branch for cosmos/gaia#834 to generate a testnet and attempt to start the chain

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[greg-szabo]

I have a feeling this is going to be an SDK issue too. @shahankhatch if that is true, can you please move it to the SDK repo issues?

[shahankhatch]

I was not able to replicate this as a gaia error (I did however encounter scenarios which would result in an error, see below). Please check the following steps; if it doesn't match your scenario, please provide steps and a copy of the error.

Here's what I did:

• I focused on the gaiad testnet command with a single node

gaiad testnet --keyring-backend test --v 1

• I ran testnet command for gaia main branch, and I also compiled gaiad using main. This testnet node started fine. I stopped this node.
• I also generated another testnet directory using the branch for Prepare gaia alpha release for cosmoshub-4.6 upgrade gaia#834, using a binary built against this branch. This testnet node started fine. I stopped the node

Two times that the testnet node gave errors is when I mixed the binary and the testnet configuration:

• using main binary against 834 testnet dirs:

ERR CONSENSUS FAILURE!!! err="stored supply should not have been nil"

• using 834 binary against main testnet dirs

ERR WARNING: Attempt to allocate proposer rewards to unknown proposer cosmosvalcons1s0vg3twnpn5v4kyxcq9tynrgf8dcqgeq7l76va. This should happen only if the proposer unbonded completely within a single block, which generally should not happen except in exceptional circumstances (or fuzz testing). We recommend you investigate immediately. module=x/distribution
3:55PM ERR CONSENSUS FAILURE!!! err="runtime error: invalid memory address or nil pointer dereference"

[colin-axner]

* using main binary against 834 testnet dirs:

ERR CONSENSUS FAILURE!!! err="stored supply should not have been nil"

This is a bug in the SDK (regression as well). Using cosmos/gaia#834, I ran the same command and you can see the supply is empty in the genesis file. But as you say, cosmos/gaia#834 binary works fine and the older binary catches the error. This indicates that the SDK is not checking supply is valid when the supply is nil (despite coins from existing in bank)

The reason you cannot replicate the error above is because the gaiad manager also runs gaiad add-genesis-account which functions correctly. It adds the genesis account and updates the supply. This results in the supply being non-nil and thus being checked.

I believe 834 against main testnet directory is due to an address migration issue and isn't a bug

[colin-axner]

Looking at the code I cannot tell if this is intentional or not. It seems the supply in genesis is unused meaning this field should be a deprecated genesis parameter. The inconsistent behaviour of updating supply/not updating supply seems problematic

[shahankhatch]

Thanks for the clear explanation @colin-axner. I agree with your point about inconsistent behaviour.

Moving this issue to the sdk.

[technicallyty]

looks like testnet and add-genesis-account were doing mostly the same things except testnet doesn't do anything to supply, and add-genesis-account does. this can be fixed by adding this to gaia/cmd/gaiad/cmd/testnet.go:

func initGenFiles(
	clientCtx client.Context, mbm module.BasicManager, chainID string,
	genAccounts []authtypes.GenesisAccount, genBalances []banktypes.Balance,
	genFiles []string, numValidators int,
) error {
    // --snip--

+    bankGenState.Balances = banktypes.SanitizeGenesisBalances(genBalances)
+    for _, bal := range bankGenState.Balances {
+	    bankGenState.Supply.Add(bal.Coins...)
+   }

    // --snip--

I'll update this in the SDK.