Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI settings prevent updates to older gaias #1449

Closed
5 tasks
Tracked by #1669
faddat opened this issue Apr 25, 2022 · 8 comments
Closed
5 tasks
Tracked by #1669

CI settings prevent updates to older gaias #1449

faddat opened this issue Apr 25, 2022 · 8 comments

Comments

@faddat
Copy link
Contributor

faddat commented Apr 25, 2022

Summary of Bug

Version

all

Steps to Reproduce

Update older versions of gaia, or in the case of the codecov issue, do anything at all

https://github.com/cosmos/gaia/runs/6164055056?check_suite_focus=true#step:8:30

Suggested solutions

  • Stop using the diff ci action
  • consider replacing codecov with a more portable solution that does not rely on an api key
  • backport this to all gaias

#1448

note

due to the fact that there seems an issue with the cosmos codecov api key generally or with the whole service, any PR's that have cone in recently will need their ci jobs re-run

this has hit tm-db as well:

https://github.com/tendermint/tm-db/runs/6163210118?check_suite_focus=true

2nd note:

it hurts more than the linters
https://github.com/faddat/gaia/blob/84de16ef50b0dad6ec164b99610a80bf16d9ec01/.github/workflows/sims.yml#L125

ci jobs are free, why are we trying to conserve them?


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@faddat faddat mentioned this issue May 26, 2022
11 tasks
@faddat
Copy link
Contributor Author

faddat commented May 26, 2022

@faddat
Copy link
Contributor Author

faddat commented May 27, 2022

yep. this one, dated a month ago, detailed the issues with all the pr's

@mmulji-ic
Copy link
Contributor

Hey @faddat do have suggestions for alternative codecov tooling?

@faddat
Copy link
Contributor Author

faddat commented Aug 1, 2022

Just had a call with @okwme -- so, we found that the linter was missing this line:

#1623
#1624

However, the main branch contains linting issues. They're not being caught because of the diff.

They are grandfathered-in. We saw this with:

@okwme
Copy link
Contributor

okwme commented Aug 1, 2022

Linting errors should all be fixed at this point in main.
Since we removed checkdiff linters will be run all the time as well.
still needs to be backported to v7.0.x (can go into current work on v7.0.3) and v6.0.x according to #1549

@okwme okwme self-assigned this Aug 1, 2022
@okwme okwme mentioned this issue Aug 15, 2022
5 tasks
@okwme
Copy link
Contributor

okwme commented Sep 19, 2022

hey @faddat i'm having trouble narrowing down what changes need to be backported for #1669
it's the last thing to close this issue, can you help with a backport PR with just the relevant changes?

@okwme okwme removed their assignment Dec 22, 2022
@faddat faddat changed the title Linters prevent updates to older gaias CI settings prevent updates to older gaias Jan 4, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jan 27, 2023
@mpoke mpoke added this to Cosmos Hub Jan 27, 2023
@mpoke mpoke added this to the Improve QA process milestone Jan 27, 2023
@mpoke mpoke moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub Jan 27, 2023
@mpoke mpoke removed this from the Improve QA process milestone Mar 5, 2023
@mpoke
Copy link
Contributor

mpoke commented Mar 6, 2023

Update:

  • understand issue with using the diff CI action
  • replace codecov with Sonarcloud (i.e., config Sonarcloud)

@mpoke mpoke moved this from 🏗 In progress to 📥 Todo in Cosmos Hub Mar 6, 2023
@mpoke
Copy link
Contributor

mpoke commented Sep 14, 2023

Closing as codecov was updated to Sonarcloud. If the problem persists, we'll reopen.

@mpoke mpoke closed this as completed Sep 14, 2023
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Sep 14, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants