Use consistent versions of golangci-lint

[ryanchristo]

Summary

Running make lint (or make lint-fix) locally produces different results than the CI check if the user has a different version of golangci-lint installed. It would be nice if running golangci-lint locally produced the same results as the CI check.

ref #9464

Problem Definition

+ There are no unexpected results from the CI check.

Proposal

We could use a golangci/golangci-lint docker container.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[augchan42]

This is the version of golangci-lint I'm using:

osboxes@osboxes:~/Home/cosmos-sdk$ golangci-lint version
golangci-lint has version 1.40.1 built from 625445b1 on 2021-05-14T11:44:45Z

[alexanderbez]

The linting actions performed by the repo via make targets should be executed against a fixed docker image. I'm not sure if this is currently the case or not, but if it's not it, I would highly recommend taking this approach.

[tac0turtle]

You could specify a version in the golangci.yml like so

golangci-lint-version: 1.23.x # use the fixed version to not introduce new linters unexpectedly

[augchan42]

I don't see a way to set the linter version at https://golangci-lint.run/usage/configuration/
Full example: https://github.com/golangci/golangci-lint/blob/master/.golangci.example.yml
The go version can be set however (default is 1.13 according to that link)

[alexanderbez]

You wouldn't -- you'd use a docker image:

e.g.

MODULE = $(shell go list -m)
GOLANGCI_LINT_CMD := $(DOCKER_CMD) run --rm -v $(shell pwd):/$(MODULE) -w /$(MODULE)\	golangci/golangci-lint:v1.35.0 golangci-lint run

lint: 
  $(GOLANGCI_LINT_CMD) ./...

[robert-zaremba]

I think the standard way for this is to run tools through go run and add them to go.mod.

[alexanderbez]

Yes. Here is an example of it being done:

Tools (idiomatic way to handle go.mod dep):
https://github.com/umee-network/umee/blob/main/tools/tools.go

Makefile target:
https://github.com/umee-network/umee/blob/main/Makefile#L132-L134

Also note, this is exactly how Tendermint does it too. If agreed upon, I can make a PR.