-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve linter errors when running make against clean repo #9460
Comments
I thought it might be due to timeout, but I increased my timeout in golangci.yml to 5 minutes and still encounter these errors. |
Additional errors after resolving the above:
|
Proposed fix for: x/distribution/legacy/v043/helpers.go:22:18 gocritic appendAssign: append result not assigned to the same slice OLD CODE: NEW CODE: |
Summary of Bug
When running make for the first time from a freshly cloned repo, there's many gofmt errors and a gocritic appendAssign error. Ideally a make should complete with no changes from a freshly cloned repo.
Version
https://github.com/cosmos/cosmos-sdk/releases/tag/v0.42.5
Steps to Reproduce
My build OS is banner is: Welcome to Ubuntu 20.04.2 LTS (GNU/Linux 5.4.0-73-generic x86_64)
After cloning the repo (e.g., 'gh repo clone cosmos/cosmos-sdk'), run 'make'. You will need to setup your environment with all pre-reqs (golangci-lint, golang-go, make, docker-ce, etc)
Here's a portion of the errors:
For Admin Use
The text was updated successfully, but these errors were encountered: