Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate tm-db #9092

Closed
2 of 4 tasks
tac0turtle opened this issue Apr 9, 2021 · 5 comments
Closed
2 of 4 tasks

Incorporate tm-db #9092

tac0turtle opened this issue Apr 9, 2021 · 5 comments
Assignees
@robert-zaremba
Labels
C:Store dependencies Pull requests that update a dependency file Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Apr 9, 2021 •
edited
Loading

Summary

Bring over the tm-db interface and 1-2 databases for support in the sdk.

Problem Definition

Too many DBs are used and the abstraction for many dbs disallows the usage of specific database features.

Proposal

Merge tm-db interface into the sdk and bring over memdb (for testing) and 1-2 databases.

We discussed this in the sdk call and have decided to move forward with this.

The preferred DBs are badger and rocksdb, if you believe this is not enough or another database should be considered, please leave a comment.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle tac0turtle added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. dependencies Pull requests that update a dependency file labels Apr 9, 2021
@tac0turtle tac0turtle mentioned this issue Apr 9, 2021
Closed
4 tasks
@robert-zaremba
Copy link
Collaborator

Related to: Storage Layer migration.

@robert-zaremba
Copy link
Collaborator

The 2 DB we tested and meet our requirements for the new storage are: BadgerDB and RocksDB.

@tac0turtle
Copy link
Member Author

https://github.com/cockroachdb/pebble

this is an option as well. It can help avoid cgo with rocksdb

@robert-zaremba robert-zaremba self-assigned this Apr 21, 2021
@robert-zaremba
Copy link
Collaborator

yes, I've put it in the discussions 2 months ago: #8297 (reply in thread)

@github-actions github-actions bot added the stale label Aug 19, 2021
@robert-zaremba
Copy link
Collaborator

closed by #9952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robert-zaremba robert-zaremba

Labels
C:Store dependencies Pull requests that update a dependency file Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robert-zaremba @clevinson @tac0turtle