Feature/go data

[ethanfrey]

Use new go-data enhanced go-crypto data structures, so we can play better with json.

go-wire encodings will remain the same as they are now. encoding/json creates nice human readable json formats, fit for a public api. Along with bringing the rpc client into tendermint, this will remove a large chunk of the boilerplate in light-client.

All json encodings can be parsed again to recover the original structure. Here is an example:

Unsigned sendtx transaction (from client)

{
  "type": "send",
  "data": {
    "gas": 1,
    "fee": {
      "denom": "foo",
      "amount": 2
    },
    "inputs": [
      {
        "address": "ac7de62488962adc31f0416612e814e291e0765e",
        "coins": [
          {
            "denom": "foo",
            "amount": 10
          }
        ],
        "sequence": 1,
        "signature": null,
        "pub_key": {
          "type": "ed25519",
          "data": "31fb78b7b5b39b0c7e25877ca5148b4ff5b4cad0c81dd9e82db50e3723f2897c"
        }
      }
    ],
    "outputs": [
      {
        "address": "1eda813cf2871fceaf2d0ffbc8c810614fbb99ff",
        "coins": [
          {
            "denom": "foo",
            "amount": 8
          }
        ]
      }
    ]
  }
}

Signed sendtx transaction. Note that this can be deterministically parsed into the original stucture and the signature valiadated, without requiring a binary interchange format - just a consistent in-memory representation (same data structures):

{
  "type": "send",
  "data": {
    "gas": 1,
    "fee": {
      "denom": "foo",
      "amount": 2
    },
    "inputs": [
      {
        "address": "ac7de62488962adc31f0416612e814e291e0765e",
        "coins": [
          {
            "denom": "foo",
            "amount": 10
          }
        ],
        "sequence": 1,
        "signature": {
          "type": "ed25519",
          "data": "b36baf76d715ff20c09b3dbf26bcb5fd9cb6db13ae5056cbf1032620962b3624cca7b9da245e042498b440c9fb13d471a45f5b30ae0350466bf492c909b21a0c"
        },
        "pub_key": {
          "type": "ed25519",
          "data": "31fb78b7b5b39b0c7e25877ca5148b4ff5b4cad0c81dd9e82db50e3723f2897c"
        }
      }
    ],
    "outputs": [
      {
        "address": "1eda813cf2871fceaf2d0ffbc8c810614fbb99ff",
        "coins": [
          {
            "denom": "foo",
            "amount": 8
          }
        ]
      }
    ]
  }
}

[ebuchman]

Should we use the XxS structs for cmd/commands/key.go ?

[ebuchman]

Great.

[ebuchman]

let's move testutils into basecoin/types - no need for the extra tiny package

[ebuchman]

I just tried to merge into develop locally. I was having trouble actually running a real basecoin with old genesis files - and when I tried to update to use the new json format for the pubkeys, I started getting issues with the int64 in the Coin being treated as some float and not co-operating. Would you mind rebasing on develop and fixing this stuff up?

Note you should make sure the ibc demo works as part of testing. We should add it to the circle piece, but just

cd demo
bash start.sh

Sometimes you need to run start.sh twice. See genesis files in ./demo/data/chainX/basecoin/genesis.json.

Run bash clean.sh before you try again