Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IsAllGTE() more consistent #3864

Merged
merged 3 commits into from
Mar 12, 2019
Merged

Make IsAllGTE() more consistent #3864

merged 3 commits into from
Mar 12, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 12, 2019

This is a sub-PR of #3678
It also removes duplicate tests.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio marked this pull request as ready for review March 12, 2019 17:23
PENDING.md Show resolved Hide resolved
Co-Authored-By: alessio <[email protected]>
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #3864 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3864      +/-   ##
===========================================
- Coverage    60.97%   60.95%   -0.02%     
===========================================
  Files          192      192              
  Lines        14342    14346       +4     
===========================================
  Hits          8745     8745              
- Misses        5027     5031       +4     
  Partials       570      570

@alessio alessio requested review from jackzampolin and mossid March 12, 2019 17:57
types/coin.go Show resolved Hide resolved
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit 7af11ec into develop Mar 12, 2019
@cwgoes cwgoes deleted the alessio/coins-IsAllGTE branch March 12, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants