We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since we are already adding an action tag in the baseApp runMsgs we should not add the same one again in the individual handler.
runMsgs
Also it might make more sense to prepend the action tag instead of appending it to make parsing more simple.
Additionally I would recommend adding a divider between data of the single messages to simplify parsing.
cosmos-sdk/baseapp/baseapp.go
Line 624 in aa72e72
Ideally we would have tags/data per message.
The text was updated successfully, but these errors were encountered:
We should indeed remove the duplicate action tags.
Tags will eventually turn into events (ref tendermint/tendermint#1859).
Sorry, something went wrong.
No branches or pull requests
Since we are already adding an action tag in the baseApp
runMsgs
we should not add the same one again in the individual handler.Also it might make more sense to prepend the action tag instead of appending it to make parsing more simple.
Additionally I would recommend adding a divider between data of the single messages to simplify parsing.
cosmos-sdk/baseapp/baseapp.go
Line 624 in aa72e72
Ideally we would have tags/data per message.
For Admin Use
The text was updated successfully, but these errors were encountered: