Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove action tag from individual handlers #2941

Closed
4 tasks
hendrikhofstadt opened this issue Nov 29, 2018 · 1 comment
Closed
4 tasks

Remove action tag from individual handlers #2941

hendrikhofstadt opened this issue Nov 29, 2018 · 1 comment

Comments

@hendrikhofstadt
Copy link
Contributor

hendrikhofstadt commented Nov 29, 2018

Since we are already adding an action tag in the baseApp runMsgs we should not add the same one again in the individual handler.

Also it might make more sense to prepend the action tag instead of appending it to make parsing more simple.

Additionally I would recommend adding a divider between data of the single messages to simplify parsing.

data = append(data, msgResult.Data...)

Ideally we would have tags/data per message.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@cwgoes
Copy link
Contributor

cwgoes commented Nov 29, 2018

We should indeed remove the duplicate action tags.

Tags will eventually turn into events (ref tendermint/tendermint#1859).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants