Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 'err' names from function return arguments in queriers #2788

Closed
fedekunze opened this issue Nov 12, 2018 · 2 comments
Closed

remove 'err' names from function return arguments in queriers #2788

fedekunze opened this issue Nov 12, 2018 · 2 comments
Labels
good first issue help wanted Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@fedekunze
Copy link
Collaborator

Originally posted by @rigelrozanski in #2565

Ref: #2565 (comment)

queriable.go uses err2/errRes for the error return values. For consistency let's use only err everywhere
@fedekunze fedekunze mentioned this issue Nov 12, 2018
Merged
5 tasks
@fedekunze fedekunze added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. help wanted good first issue labels Nov 12, 2018
@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 12, 2018 •
edited
Loading

Yes pweeeez 🙌

Also, we should remove named return variables where it's obviously clear what the context is and the function/method is concise.

@0xforever9 0xforever9 mentioned this issue Jun 2, 2019
Merged
5 tasks
@tac0turtle
Copy link
Member

@fedekunze & @alexanderbez has then been solved, seems the PR from 4ever9 solved most to all of them

@snyk-bot snyk-bot mentioned this issue Jul 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexanderbez @tac0turtle @fedekunze