Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coins.IsLT() is not the same as !Coins.IsGTE() #2674

Closed
jaekwon opened this issue Nov 3, 2018 · 2 comments
Closed

Coins.IsLT() is not the same as !Coins.IsGTE() #2674

jaekwon opened this issue Nov 3, 2018 · 2 comments
Assignees
@jaekwon @alessio

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Nov 3, 2018

cosmos-sdk/types/coin.go

Line 192 in de099b4

func (coins Coins) IsLT(coinsB Coins) bool {

@jaekwon jaekwon self-assigned this Nov 3, 2018
@alexanderbez
Copy link
Contributor

That's not the same code as on develop. What case(s) does it not cover?

@jaekwon jaekwon mentioned this issue Nov 5, 2018
Merged
4 tasks
@alexanderbez
Copy link
Contributor

Closed via #2686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaekwon jaekwon

@alessio alessio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaekwon @alessio @alexanderbez