R4R: Various sign command improvements #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2558 +/- ##
===========================================
- Coverage 58.84% 58.84% -0.01%
===========================================
Files 152 152
Lines 9424 9425 +1
===========================================
Hits 5546 5546
- Misses 3508 3509 +1
Partials 370 370 |
fedekunze
reviewed
Oct 22, 2018
alessio
force-pushed
the
alessio/sign-command
branch
from
01e9870 to
a6229ab
Compare
alessio
changed the title
alexanderbez
suggested changes
Oct 23, 2018
There was a problem hiding this comment.
@alessio haven't gotten a chance to play with this yet, but I left some initial minor feedback.
x/auth/client/cli/sign.go
Outdated
| flagAppend = "append" | ||
| flagPrintSigs = "print-sigs" | ||
| flagOffline = "offline" | ||
| flagRawSignature = "raw-signature" |
There was a problem hiding this comment.
What's the diff between print-sigs and raw-signature? May I suggest renaming --raw-signature to --sig-only. Also, let's not jumble sig/s with signature/s. Let's stick to one.
There was a problem hiding this comment.
I rename --raw-signature to --sig-only. Plus, I renamed --print-sigs to --validate-signatures.
alessio
force-pushed
the
alessio/sign-command
branch
from
4768498 to
ab36fba
Compare
|
@alessio let's add the new flags on |
alexanderbez
approved these changes
Oct 31, 2018
added 11 commits
October 31, 2018 13:41
- Exit with error if the user is attempting to sign with a key whose address is not among those who are expected to sign the transaction. - Add --print-signature-only to output only the generated signature.
alessio
force-pushed
the
alessio/sign-command
branch
from
9ab5733 to
3df3337
Compare
alessio
force-pushed
the
alessio/sign-command
branch
from
3df3337 to
06989be
Compare
cwgoes
approved these changes
Oct 31, 2018
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: