-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock binary dependencies to a specific commits / versions #2464
Conversation
This is basically copying over @anton's great script! Also had to run `make format` to make this pass `test_lint`. This PR also makes the make commands for tools further align with the tendermint implementation.
Codecov Report
@@ Coverage Diff @@
## develop #2464 +/- ##
=======================================
Coverage 61.9% 61.9%
=======================================
Files 149 149
Lines 9530 9530
=======================================
Hits 5900 5900
Misses 3213 3213
Partials 417 417 |
ba7cad2
to
58bedad
Compare
Hmm, |
Fixed, it was an issue with the circle config. I hadn't realized lint didn't already have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor questions.
scripts/get_tools.sh
Outdated
# specific git hash. | ||
# | ||
# repos it installs: | ||
# github.com/mitchellh/gox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think so? Maybe this comment was copied from Tendermint?
Now this is causing Did we pick the revision we're using on |
Oh I didn't use our golint :l. I'm not a fan of tendermint/golint (which is only used in the sdk) being a thing :l |
I don't think its worth restructuring the script for tendermint/lint (as its download must come after gometalinter installs linters). Reasoning I don't think its worth restructuring 1 because its our own repo, and 2 we're planning on phasing that out anyway (once someone gets time, or postlaunch). Because of that, I'll implement a slightly more "hacky" solution, which I don't actually think is bad |
32c7485
to
b11afc9
Compare
b11afc9
to
a703e6e
Compare
This is basically copying over @anton's great script!
Also had to run
make format
to make this passtest_lint
.This PR also makes the make commands for tools further align
with the tendermint implementation.
closes #1809
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests - n/a
Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: