R4R: Aggressive slashing simulation & fixes #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref #2305 (comment) |
cwgoes
force-pushed
the
cwgoes/aggressive-slashing-simulation
branch
from
3da9957 to
74e4a40
Compare
cwgoes
force-pushed
the
cwgoes/aggressive-slashing-simulation
branch
from
74e4a40 to
9a4249e
Compare
Codecov Report
@@ Coverage Diff @@
## cwgoes/nextvalset #2430 +/- ##
==================================================
Coverage 59.71% 59.71%
==================================================
Files 136 136
Lines 8410 8410
==================================================
Hits 5022 5022
Misses 3055 3055
Partials 333 333 |
This was referenced Oct 5, 2018
cwgoes
changed the title
|
Ready for review but dependent on #2255. |
ValarDragon
reviewed
Oct 5, 2018
| @@ -14,7 +14,7 @@ const ( | |||
| numKeys int = 250 | |||
|
|
|||
| // Chance that double-signing evidence is found on a given block | |||
| evidenceFraction float64 = 0.01 | |||
| evidenceFraction float64 = 0.5 | |||
There was a problem hiding this comment.
We probably should randomize this. Also .5 seems a bit too high lol.
Setting a high evidence fraction isn't sufficient tho, since it executes a different code path than liveness (Or in this bloxk) slashes
There was a problem hiding this comment.
Doesn't block this PR, it lgtm!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2255
Closes #2396
Closes #2225
Closes #2224
Does not yet solve #2372 because the cause of that issue is not yet clear.
Usual checklist:
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: