Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: app v2: empty valset after init genesis #21907

Closed
1 task done
alpe opened this issue Sep 25, 2024 · 1 comment · Fixed by #22729
Closed
1 task done

[Bug]: app v2: empty valset after init genesis #21907

alpe opened this issue Sep 25, 2024 · 1 comment · Fixed by #22729
Assignees
Labels
C:server/v2 Issues related to server/v2 T:Bug

Comments

@alpe
Copy link
Contributor

alpe commented Sep 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

After the memtree iterator fix was fixed, a new issue popped up in app v2 sims.
Although there are validators setup in genesis json, the init chain call does not return any.

After some debugging, I found out that ApplyAndReturnValidatorSetUpdates is called twice. On init-genesis and on end-block. In the second call, the validator power has not changed so an empty list is returned. Not sure why it was working before.

Cosmos SDK Version

main

How to reproduce?

No response

@alpe alpe added the T:Bug label Sep 25, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Sep 25, 2024
@julienrbrt julienrbrt added the C:server/v2 Issues related to server/v2 label Sep 26, 2024
@tac0turtle tac0turtle changed the title [Bug]: app v2: empyt valset after init genesis [Bug]: app v2: empty valset after init genesis Sep 26, 2024
@julienrbrt julienrbrt self-assigned this Nov 19, 2024
@julienrbrt
Copy link
Member

Looks like the validator updates from InitGenesis are ignored and we call DeliverBlock which does the Begin/Blocker flow, where those are returned

@julienrbrt julienrbrt moved this from 🤸‍♂️ In Progress to 👀 Waiting / In review in Cosmos-SDK Dec 3, 2024
@github-project-automation github-project-automation bot moved this from 👀 Waiting / In review to 🥳 Done in Cosmos-SDK Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2 T:Bug
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

4 participants