-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic when updating DefaultPowerReduction
#19321
Comments
@tac0turtle can you help me :) |
it looks like you have two validators with the same key, did you run some sort of migration or in the gentx you need to make sure you use unique validators |
DefaultPowerReduction
DefaultPowerReduction
I don't have two validators with same key. This error occurred when I was delegating. I launched the chain with a modified version of |
I guess simply updating
|
Might be related: #9447 |
You cannot just simply update |
Thanks guys @facundomedica @alexanderbez. How to do |
If you do change it however, you are responsible for updating all validator's powers via the app's upgrade handler. I think EVMOS did this but I'm not sure. Maybe you can reach out to them to see how/if they did it. |
@alexanderbez thanks for the update! Can we confirm that Just want to make sure if we update, there aren't other places broken. |
DefaultPowerReduction
DefaultPowerReduction
DefaultPowerReduction
DefaultPowerReduction
@facundomedica @alexanderbez Hi, I have created some code to upgrade all validator's powers via the app's upgrade handler, but it also got the same error (duplicated validator entry). Are there any problems with this change which updates the validator's voting power? Thanks |
@zhangjiannan I believe the safest thing to do is to update all validator's powers. |
thanks @alexanderbez however without updating |
The duplicated validator entry error comes with updated vp values, therefore the validator voting powers have already been updated. Now the question is why there is a duplicated entry, probably because |
@alexanderbez hi, i have added some |
@VegeBun-csj I believe you first have to delete the validator in the power index: |
@facundomedica @alexanderbez We find this issue and need to perform a |
Thanks for helping on this issue! We have updated power stores through the upgrade handler. A first round of testing suggests that the migration is successful. However, further testing is underway. We will update when we make further progress. Thank you once again for your assistance :) |
yes |
The network had been fully recovered on Feb 15th and all validators' vp has been updated. Thanks to @alexanderbez @facundomedica for help and discussion. |
Nice job 🙌 🙌 |
Is there an existing issue for this?
What happened?
ERR CONSENSUS FAILURE!!! err="failed to apply block; error commit failed for application: error changing validator set: duplicate entry Validator{1E425B3D29A4D3052E4A57F3C942A8FB13961967 PubKeyEd25519{819B2CF5A95750A20DC0EA9AFEE92E7A4895D85FF52BCB21A16C03C6D6798A1D} VP:510000 A:0} in [Validator{1E425B3D29A4D3052E4A57F3C942A8FB13961967 PubKeyEd25519{819B2CF5A95750A20DC0EA9AFEE92E7A4895D85FF52BCB21A16C03C6D6798A1D} VP:510000 A:0}Validator{1E425B3D29A4D3052E4A57F3C942A8FB13961967 PubKeyEd25519{819B2CF5A95750A20DC0EA9AFEE92E7A4895D85FF52BCB21A16C03C6D6798A1D} VP:510000 A:0}]"
Cosmos SDK Version
0.47.5
How to reproduce?
we use decimal 18 before and meet voting power overflow, So we changed the
DefaultPowerReduction
to fix it. But when i start the chain and delegate to a validator, it meets the above error. This is my commit, are there any question in this change?The text was updated successfully, but these errors were encountered: