[Bug]: LCD queries with {denom} don't work with slashes

[jcompagni10]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

I cannot find a way to use an ibc denom as part of the path for bank endpoints with a {denom} argument when making an HTTP request.
ie. cosmos/bank/v1beta1/denom_owners/{denom} or cosmos/bank/v1beta1/denoms_metadata/{denom}

cosmos/bank/v1beta1/denom_owners/ibc/FDEA8DF3742C0148CB1E04B2996823076AD960566AC20DFB8B0BA583B4BC0C56 returns a 501
as does cosmos/bank/v1beta1/denom_owners/ibc%2FFDEA8DF3742C0148CB1E04B2996823076AD960566AC20DFB8B0BA583B4BC0C56 (percent encoded)

I have tried a number of other permutations for encoding and cannot get it to work.
Is there a workaround here? Or is the routing simply unable to accept a "/" in the URL string.

Cosmos SDK Version

0.47

How to reproduce?

curl https://lcd.osmosis.zone/cosmos/bank/v1beta1/denom_owners/ibc/FDEA8DF3742C0148CB1E04B2996823076AD960566AC20DFB8B0BA583B4BC0C56

[facundomedica]

Hi, please take a look at #17493 , seems that this is not an issue for versions later than v0.46 (Osmosis might haven't backported the specific fix to their fork). Although for denom_owners it is still an issue

[jcompagni10]

I am trying to get this to work on neutron running v0.47.6 and still having the same problem.

https://rest-kralum.neutron-1.neutron.org/cosmos/bank/v1beta1/denom_owners/ibc%2F00230C58F1540708067850B3362C8A67A273FC52F0C7305B802D7255495C86FD

[jcompagni10]

Also, I know some of the endpoints now allow for a query param to supply {denom}, but I am only asking about the ability to supply the denom as a path parameter.

[tac0turtle]

upgrading to grpc-gateway v2 fixes this. This is being worked on here #18872.

[puneet2019]

^ facing the same. can we do DenomOwners2, without the {denom} in URL? so it takes it as url?denom=ibc/xxx
I believe everything remains the same.
in protos

 rpc DenomOwners2(QueryDenomOwnersRequest) returns (QueryDenomOwnersResponse) {
    option (cosmos.query.v1.module_query_safe) = true;
    option (google.api.http).get               = "/cosmos/bank/v1beta1/denom_owners";
  }

in grpc querier

func (k BaseKeeper) DenomOwners2(
	goCtx context.Context,
	req *types.QueryDenomOwnersRequest,
) (*types.QueryDenomOwnersResponse, error) {
	return k.DenomOwners(goCtx, req)
}

[puneet2019]

^ Looking at the grpc-gateway v2, i believe it can be backported. so no need of hacks.

[alexanderbez]

According to @tac0turtle, we can't simply bump the grpcgateway dep to v2, as we have downstream deps that would break clients if we made the update. I'm not sure of the exact specifics, so perhaps @tac0turtle can chime in.

[tac0turtle]

@puneet2019 @jcompagni10 are you guys using the rest endpoints in the browser or?

[puneet2019]

@tac0turtle curl, browser both..

I had to get some data for airdrop users, some nodes didn't allow archival queries via grpc ( it works there ).. so had to fallback to rest ( do not usually use it ). but I got around it after grpc started working.