Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect example to set multiple denoms for mininum-gas-prices #18536

Closed
1 task done
pwnfoo opened this issue Nov 22, 2023 · 1 comment · Fixed by #18537
Closed
1 task done

[Bug]: Incorrect example to set multiple denoms for mininum-gas-prices #18536

pwnfoo opened this issue Nov 22, 2023 · 1 comment · Fixed by #18537
Assignees
Labels

Comments

@pwnfoo
Copy link

pwnfoo commented Nov 22, 2023

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

What?

The example comment in app.toml uses ; as the separator for specifying multiple denominations for minimum gas price.

Following the example leads to a panic when the application starts :

panic: invalid minimum gas prices: invalid decimal coin expression: 0.025ufoo;0.025ubar

This issue arises because the SetMinGasPrices function calls ParseDecCoins, which uses , as the separator

Solution

  • Update the example comment to
# transaction. A transaction's fees must meet the minimum of any denomination
# specified in this config (e.g. 0.25token1,0.0001token2).
@pwnfoo pwnfoo added the T:Bug label Nov 22, 2023
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Nov 22, 2023
@julienrbrt
Copy link
Member

I think the issues comes from

baseapp.SetMinGasPrices(cast.ToString(appOpts.Get(FlagMinGasPrices))),
.

The config getter and setter seem to be working both properly with ; delimitation.
That does not change the bug, and they should both behave the same for sure.

@julienrbrt julienrbrt self-assigned this Nov 22, 2023
@julienrbrt julienrbrt moved this from 👀 To Do to ✍ In Progress in Cosmos-SDK Nov 22, 2023
@github-project-automation github-project-automation bot moved this from ✍ In Progress to 🥳 Done in Cosmos-SDK Nov 22, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants