[Feature]: x/Auth and x/tx module common types unification/conversion

[bizk]

Summary

There are common types in x/auth and x/signing modules that represent the same type of information but with different/old types,

This break interoperability between modules, and makes maintainability difficult.

Problem Definition

Example of SignerData type on both modules. The pubkey should follow crypto module type cryptotypes for public keys. But only one of these do, trying to communicate between modules that use one or antoher require to parse one into another.

x/auth/signing/sign_mode_handler.go

type SignerData struct {
	Address string
	ChainID string
	AccountNumber uint64
	Sequence uint64-
	
	PubKey cryptotypes.PubKey
}

x/tx/signing/signer_data.go

type SignerData struct {
	Address string
	ChainID string
	AccountNumber uint64
	Sequence uint64-
	
	PubKey *anypb.Any
}

Proposed Feature

Let's clean up the modules and agree on maintaining the common type in one place

[julienrbrt]

Was it maybe done for simplifying the dependency graph? cc @kocubinski

[tac0turtle]

yes, also transaction handling shoulnt be part of auth. The types in auth/tx will be removed in the future they are legacy types right now. We should mark them as such to avoid confusion

[kocubinski]

that's right, in v0.50 signing is handled in x/tx, so the duplicate type in x/auth is deprecated.

[tac0turtle]

Should we remove the types in auth since they are still in the release branch?

[tac0turtle]

we merged quite a bit