Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Rosetta dependency missmatch #16273

Closed
Tracked by #16220
bizk opened this issue May 24, 2023 · 1 comment
Closed
Tracked by #16220

[Bug]: Rosetta dependency missmatch #16273

bizk opened this issue May 24, 2023 · 1 comment
Assignees
Labels
C:Rosetta Issues and PR related to Rosetta T:Bug

Comments

@bizk
Copy link
Contributor

bizk commented May 24, 2023

Summary of Bug

Rosetta standalone under tools/rosetta uses parts of code that haven't been released yet, when a user tries to use some features of rosetta implementation, it might crash due to missing interfaces/functions which are being used by rosetta but not on the latest release v0.47.x

See these lines of code

// TODO: remove after merge of https://github.com/cosmos/cosmos-sdk/pull/15873 and tagging releases
replace (
	cosmossdk.io/collections => ../../collections // TODO: remove me after collections v0.2.0 is released
	cosmossdk.io/store => ../../store
	cosmossdk.io/x/tx => ../../x/tx
	github.com/cosmos/cosmos-sdk => ../..
)

Version

main / latest

Steps to Reproduce

Import a Rosetta from cosmos-sdk into a new project and try to parse transactions with locks for example.

@bizk bizk added the T:Bug label May 24, 2023
@bizk
Copy link
Contributor Author

bizk commented May 24, 2023

@Zondax team already solved this issue as part of it's Rosetta commitment, the PR is in the way.

@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Jun 22, 2023
@ainhoa-a ainhoa-a added the C:Rosetta Issues and PR related to Rosetta label Jun 22, 2023
@ainhoa-a ainhoa-a moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jun 22, 2023
@bizk bizk closed this as completed Jul 24, 2023
@github-project-automation github-project-automation bot moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Jul 24, 2023
@tac0turtle tac0turtle moved this to 🥳 Done in Cosmos-SDK Nov 16, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta Issues and PR related to Rosetta T:Bug
Projects
None yet
Development

No branches or pull requests

2 participants