Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: make all commands use --from #1606

Closed
ValarDragon opened this issue Jul 9, 2018 · 3 comments · Fixed by #1748
Closed

cli: make all commands use --from #1606

ValarDragon opened this issue Jul 9, 2018 · 3 comments · Fixed by #1748

Comments

@ValarDragon
Copy link
Contributor

Currently gov submit-proposal has --proposer instead of --from
Currently stake delegate has --address-delegator instead of --from.

I think this is incredibly confusing. For any transaction where this field should be populated by "Who is sending the transaction", the flag should always support the alias --from. I think this should support just --from, and not the alternatives.

@fedekunze
Copy link
Collaborator

Same with gov vote that has --voter

@rigelrozanski
Copy link
Contributor

I could work on this this week unless @ValarDragon wants to?

@rigelrozanski rigelrozanski self-assigned this Jul 16, 2018
@ValarDragon
Copy link
Contributor Author

I have no plans to work on this. (I'm trying to move to doing more tendermint things) Please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants