Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Promotheus with gaiad and gaiacli #1409

Closed
adrianbrink opened this issue Jun 27, 2018 · 7 comments
Closed

Integrate Promotheus with gaiad and gaiacli #1409

adrianbrink opened this issue Jun 27, 2018 · 7 comments
Assignees

Comments

@adrianbrink
Copy link
Contributor

adrianbrink commented Jun 27, 2018

@greg-szabo

Edit (2018-07-01):

It would be nice if the sdk and the hub ship their own metrics to promotheus.

@ebuchman
Copy link
Member

AFAIK this just means upgrade for the new tendermint with prometheus support. though maybe we want to include metrics at the SDK level too

@alexanderbez
Copy link
Contributor

I'm a bit confused. Are we simply stating the we need to upgrade the version of Tendermint in the SDK or do we also want to expose additional separate SDK metrics (e.g. total gets, total puts, request metrics, validator stats, etc...)?

@alexanderbez
Copy link
Contributor

I think the latter couldn't hurt.

@ebuchman ebuchman added this to the 1.0 Code Freeze milestone Jul 5, 2018
@ebuchman
Copy link
Member

ebuchman commented Jul 5, 2018

I think the request is to update to the latest tendermint.

But I'm also not sure prometheus is the correct tool for tracking info about the state machine. It would have to persist data and stay synced with the blockchain properly. More likely we should keep it focused on information about the running process, rather than getting involved with the SDK state machine. Though it could be used to track reads/writes to the underlying db and maybe latency spent in AVL store access. @xla does that sound right?

Getting metrics on the db/avl access sounds pretty useful, so let's leave this open for that.

@alexanderbez
Copy link
Contributor

Ok cool, so I'll boil this down to:

  • Update to latest TM
  • Expose Prom metrics on DB/IAVL+ ops

Correct?

@xla
Copy link

xla commented Jul 5, 2018

Generally anything that requires state to be kept is not a good candidate for prometheus and as pointed out any quantitive information e.g. number of operations, errors, latencies and beyond that dimensional breakdown with tags e.g. operation type, endpoint, error type. There is some information which fits well into gauges which could value beyond operational insight. An interesting exercise would be to actually compile a list of potential metrics and see if they would work with the prometheus modle and if it is feasible to track.

@alexanderbez
Copy link
Contributor

Can we close this @ebuchman? Seems like we want to create a ticket for compiling a list of potential metrics (most likely gauges). Doesn't seem super high priority atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants