No color highlight in logs

[julienrbrt]

Summary of Bug

No color highlight in logs on using simd on main:

v0.45/v0.46

I suspect #13236 to be the reason (however I have not verified). Is it intended? If so we can close this.

Version

main

Steps to Reproduce

simd start

[tac0turtle]

Since we removed zero log in favor of the previous filter logging we lost the coloring. To get the coloring back we would need to rewrite the zerlogger with filtering in mind

[alexanderbez]

Since we removed zero log in favor of the previous filter logging we lost the coloring. To get the coloring back we would need to rewrite the zerlogger with filtering in mind

Yup (RIP Zerolog)

[julienrbrt]

Can you tell me what are the requirements of the logger? Is it mainly filtering?
How filtering works btw, how to use it?

[tac0turtle]

here is the filtering we use: https://github.com/tendermint/tendermint/blob/main/libs/log/filter.go. There is a way to do this with zero logger, just requires some changes

Also I don't have color logging with 0.45 on my nodes, so think this is a low priority thing

[robert-zaremba]

Colored logging should be optional (definitely not enforced)

[alexanderbez]

TBH, this typically is automatically handled for you via the logging library. E.g. logs are typically written in either structured format (i.e. JSON) or human-friendly (i.e. text). When it's text, it should automatically be colored.

[robert-zaremba]

When it's text, it should automatically be colored.

agree, but it should be optional. Typical use case: redirecting logs textual logs.

[julienrbrt]

Superseded by #14967