Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making staking more REST-ful #1272

Closed
faboweb opened this issue Jun 15, 2018 · 4 comments
Closed

Making staking more REST-ful #1272

faboweb opened this issue Jun 15, 2018 · 4 comments
Labels
C:x/staking S:proposed

Comments

@faboweb
Copy link
Contributor

faboweb commented Jun 15, 2018

cosmos-sdk/x/stake/client/rest/query.go

Line 17 in 0866494

"/stake/{delegator}/bonding_status/{validator}",

How about basing the url structure around entities to make queries more readable

get validators: GET /stake/validators
delegate: POST /stake/delegations
build delegation tx to be signed client side: GET /stake/delegations/build
get stake for a delegator: GET /stake/delegations?delegator={delegatorAddress}
@cwgoes
Copy link
Contributor

cwgoes commented Jun 16, 2018 •
edited
Loading

Concept ACK - as long as PUT/POST cleanly map to single transactions.

Can we do this for the whole LCD API?

@faboweb
Copy link
Contributor Author

faboweb commented Jun 16, 2018

It is mostly the case already.

@faboweb
Copy link
Contributor Author

faboweb commented Jun 18, 2018

Issue for governance: #1284

@adrianbrink adrianbrink mentioned this issue Jun 21, 2018
Closed
2 tasks
@fedekunze
Copy link
Collaborator

Closed by #1880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/staking S:proposed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ebuchman @faboweb @cwgoes @fedekunze