Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Slashing Spec Tracking #1256

Closed
8 of 9 tasks
cwgoes opened this issue Jun 14, 2018 · 13 comments
Closed
8 of 9 tasks

Write Slashing Spec Tracking #1256

cwgoes opened this issue Jun 14, 2018 · 13 comments
Assignees
Milestone

Comments

@cwgoes cwgoes self-assigned this Jun 14, 2018
@rigelrozanski
Copy link
Contributor

Sounds comprehensive 👍 - we should structure the spec to be consistent with the other specs - to have detailed outline of the state, and reference all transactions/events as to how they affect that state.

@ebuchman
Copy link
Member

Sounds like some of this is in https://github.com/cosmos/cosmos-sdk/pull/1263/files but we should go through it again and make sure every thing is clear

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 15, 2018

We haven't thought through / categorized "network attack scenarios" yet, I think that would be useful.

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 19, 2018

Also still to-do in the spec: slashing transactions (MsgUnrevoke).

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 23, 2018

also ref #1348

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 28, 2018

More reasons to write a precise "slashing security model": #1378, #1440

@rigelrozanski
Copy link
Contributor

thanks for posting these links - commented on both

@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 24, 2018

Another note: the Tendermint validator-set-delayed-by-a-block changes need to change the slashing rules, since stake now contributes to voting power a block after it was unbonded/redelegated.

@cwgoes cwgoes changed the title Write slashing spec Write slashing spec [meta issue] Jul 27, 2018
@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 1, 2018

Also tagging tendermint/tendermint#2112 which would need to be implemented by the SDK also if we decide to add it to Tendermint.

@jackzampolin
Copy link
Member

Just a couple more items here!

@jackzampolin jackzampolin changed the title Write slashing spec [meta issue] Write Slashing Spec Tracking Oct 12, 2018
@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 12, 2018

Just a couple more items here!

Well, yes and no. The logic is relatively well specified, but we have little of the attack scenario enumeration, economic cost analysis, and light client-related explanation (successfully lying to a light client should always be a slashable offense).

@jackzampolin
Copy link
Member

More work has been done here right @cwgoes? Do you mind updating this issue with the remaining Slashing spec work to be done?

@cwgoes
Copy link
Contributor Author

cwgoes commented Dec 8, 2018

I think we still lack a comprehensive explanation of the incentive design rationale. The original issue's list of requirements are accurate.

I plan to work on this while rectifying staking/slashing code / spec, hopefully next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants