-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Slashing Spec Tracking #1256
Comments
Sounds comprehensive 👍 - we should structure the spec to be consistent with the other specs - to have detailed outline of the state, and reference all transactions/events as to how they affect that state. |
Sounds like some of this is in https://github.com/cosmos/cosmos-sdk/pull/1263/files but we should go through it again and make sure every thing is clear |
We haven't thought through / categorized "network attack scenarios" yet, I think that would be useful. |
Also still to-do in the spec: slashing transactions ( |
also ref #1348 |
thanks for posting these links - commented on both |
Another note: the Tendermint validator-set-delayed-by-a-block changes need to change the slashing rules, since stake now contributes to voting power a block after it was unbonded/redelegated. |
Also tagging tendermint/tendermint#2112 which would need to be implemented by the SDK also if we decide to add it to Tendermint. |
Just a couple more items here! |
Well, yes and no. The logic is relatively well specified, but we have little of the attack scenario enumeration, economic cost analysis, and light client-related explanation (successfully lying to a light client should always be a slashable offense). |
More work has been done here right @cwgoes? Do you mind updating this issue with the remaining Slashing spec work to be done? |
I think we still lack a comprehensive explanation of the incentive design rationale. The original issue's list of requirements are accurate. I plan to work on this while rectifying staking/slashing code / spec, hopefully next week. |
Including:
Sub-concerns:
The text was updated successfully, but these errors were encountered: