-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream GDA based decimal type #11783
Comments
Assuming we have a |
If we agree the regen API and behavior is what we want. It is based off of 128-bit decimal arithmetic, but can have configurable rounding |
Is there anything blocking adding the Regen version? I can port the it if nobody is looking at it. |
I don't have a ton of context here, but I wanted to bring this Twitter feedback here: https://twitter.com/smsunarto/status/1676769181520523265 Scott also mentions that regen's wrapper cures the issue he was describing. Go Regen! |
done |
Based on the discussions in #7773, the decision regarding decimals in the SDK is to use a GDA-based decimal implementation to replace the current
sdk.Dec
.This would likely be based on one of these two libraries and we should plan on providing upstream changes when needed:
This new decimal type should likely go into a new standalone
math
go module along with a copy of the currentsdk.Int
implementation so these are broken out of the monolithic SDK.The apd-based
Dec
wrapper type in regen-ledger can possibly be the basis for this newmath.Dec
type: https://github.com/regen-network/regen-ledger/tree/master/types/mathThe text was updated successfully, but these errors were encountered: