Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegations should use Percents or Amounts #1122

Closed
rigelrozanski opened this issue Jun 2, 2018 · 6 comments
Closed

Delegations should use Percents or Amounts #1122

rigelrozanski opened this issue Jun 2, 2018 · 6 comments

Comments

@rigelrozanski
Copy link
Contributor

Remove the use of "Max" shares - just 100% Shares

Based on feedback from validators

@cwgoes
Copy link
Contributor

cwgoes commented Jun 5, 2018

Wasn't there a concern about limited rational precision (IIRC correctly from a discussion)?

Or do you mean literally having the transaction take a percentage?

@rigelrozanski
Copy link
Contributor Author

Yeah - if limited rational precision is an issue we need to fix it anyways - and yes I mean literally taking a percentage - ex. you could redelegate either "5 delegator shares" or "10% of your delegator shares held in a bond"

@cwgoes
Copy link
Contributor

cwgoes commented Jun 5, 2018

If we fix limited rational precision, can't this just be done at the UI layer? What reason would we have to compute the percentages on-chain?

I agree gaiacli could expose percentages though.

@rigelrozanski
Copy link
Contributor Author

Oh alright - I like just adding it to gaiacli, only downside is gaiacli has to do a query if percentage is chosen

@ValarDragon
Copy link
Contributor

Do we want gaiacli to round down or just do standard rounding when giving percentages?

@rigelrozanski
Copy link
Contributor Author

I don't think it actually needs to round as it's using rational math - just multiple the percent and pass the result rational in the message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants