-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegations should use Percents or Amounts #1122
Comments
Wasn't there a concern about limited rational precision (IIRC correctly from a discussion)? Or do you mean literally having the transaction take a percentage? |
Yeah - if limited rational precision is an issue we need to fix it anyways - and yes I mean literally taking a percentage - ex. you could redelegate either "5 delegator shares" or "10% of your delegator shares held in a bond" |
If we fix limited rational precision, can't this just be done at the UI layer? What reason would we have to compute the percentages on-chain? I agree |
Oh alright - I like just adding it to gaiacli, only downside is gaiacli has to do a query if percentage is chosen |
Do we want gaiacli to round down or just do standard rounding when giving percentages? |
I don't think it actually needs to round as it's using rational math - just multiple the percent and pass the result rational in the message |
Remove the use of "Max" shares - just 100% Shares
Based on feedback from validators
The text was updated successfully, but these errors were encountered: