Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go.mod replace line for gin-gonic/gin #10409

Closed
4 tasks
amaury1093 opened this issue Oct 20, 2021 · 6 comments · Fixed by #20140
Closed
4 tasks

Remove go.mod replace line for gin-gonic/gin #10409

amaury1093 opened this issue Oct 20, 2021 · 6 comments · Fixed by #20140
Labels
dependencies Pull requests that update a dependency file Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@amaury1093
Copy link
Contributor

Summary of Refactor

Remove this line

replace github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.7.0

Version

After #10401

Proposal

  • Wait for all the SDK's dependencies that use gin-gonic/gin to update to >=v1.7.0
  • Remove the above line
  • Make sure there's no mention of gin-gonic/gin<1.7.0 in go.sum

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. dependencies Pull requests that update a dependency file labels Oct 20, 2021
@fer-correa
Copy link

Hi @AmauryM, could you assign this issue to me?

I'm looking for contribute on Go projects repos and (my main objective) blockchain projects.

I would love to help and continually contribute on this repo.

@amaury1093
Copy link
Contributor Author

Sure! Make sure to double check that all cosmos deps that import gin-gonic/gin, actually already updated their gin-gonic/gin dep to >=1.7.0.

Feel free to create a PR anytime.

@facundomedica
Copy link
Member

Ref: coder/websocket#332 (looks unmaintained 😢 )

go mod why -m github.com/gin-gonic/gin
# github.com/gin-gonic/gin
github.com/cosmos/cosmos-sdk/server/grpc
github.com/improbable-eng/grpc-web/go/grpcweb
nhooyr.io/websocket
nhooyr.io/websocket.test
github.com/gin-gonic/gin

@ryanchristo
Copy link
Contributor

Any thoughts regarding the use of a fork that is maintained? coder/websocket#332 (comment)

@ryanchristo
Copy link
Contributor

This and gogo protobuf are the only blockers for regen to use go install in future releases.

@faddat
Copy link
Contributor

faddat commented Sep 4, 2022

isn't this issue now closed? I just checked through things, and we're only referencing the old version in the submodules that import v0.46.1.

We might be able to cure this -- if the goal is to use go install (it is a great goal) -- by using https://github.com/notional-labs/websocket or coder/websocket#332 (comment)

in v0.46.2

I am not sure about gogo/protobuf; I expect that'll be a good deal harder.

@tac0turtle tac0turtle mentioned this issue Apr 22, 2024
12 tasks
@github-project-automation github-project-automation bot moved this from Icebox to Done in Cosmos SDK Maintenance Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants