From 2b02f066aae39cd2ece720e2616acf5b3308bf8e Mon Sep 17 00:00:00 2001 From: Tim Lind Date: Wed, 10 Nov 2021 19:15:01 +0200 Subject: [PATCH] fix: pass through broadcast mode for signing with amino flag (#10510) ## Description Fixes signing with amino flag. Closes: #9671 Passes through broadcast mode flag value. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --- x/auth/client/cli/tx_sign.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/x/auth/client/cli/tx_sign.go b/x/auth/client/cli/tx_sign.go index 08abeaa0597..6c869d4b97b 100644 --- a/x/auth/client/cli/tx_sign.go +++ b/x/auth/client/cli/tx_sign.go @@ -263,6 +263,11 @@ func makeSignCmd() func(cmd *cobra.Command, args []string) error { return err } + bMode, err := f.GetString(flags.FlagBroadcastMode) + if err != nil { + return err + } + var json []byte if aminoJSON { stdTx, err := tx.ConvertTxToStdTx(clientCtx.LegacyAmino, txBuilder.GetTx()) @@ -271,7 +276,7 @@ func makeSignCmd() func(cmd *cobra.Command, args []string) error { } req := BroadcastReq{ Tx: stdTx, - Mode: "block|sync|async", + Mode: bMode, } json, err = clientCtx.LegacyAmino.MarshalJSON(req) if err != nil {