Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bot to keep up with upstream #3

Open
amaury1093 opened this issue Sep 22, 2021 · 1 comment
Open

Add bot to keep up with upstream #3

amaury1093 opened this issue Sep 22, 2021 · 1 comment

Comments

@amaury1093
Copy link

No description provided.

@conr2d
Copy link
Collaborator

conr2d commented Sep 23, 2021

We changed the function signature from Decode(string) to Decode(string, int) not to break with SDK.
https://github.com/cosmos/cosmos-sdk/blob/6e70d25d/types/bech32/bech32.go#L21

To keep up with upstream (btcsuite/btcutil) by bot, we need to make SDK call Decode(string) to avoid merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants