Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secp256r1 signature support #17

Closed
aaronc opened this issue Oct 25, 2019 · 9 comments
Closed

Add secp256r1 signature support #17

aaronc opened this issue Oct 25, 2019 · 9 comments
Assignees
Labels
Milestone

Comments

@aaronc
Copy link
Collaborator

aaronc commented Oct 25, 2019

Also known as NIST P-256. See cosmos#4789

@aaronc aaronc added this to the Hudson milestone Oct 25, 2019
@aaronc aaronc added the backlog label Oct 25, 2019
@aaronc
Copy link
Collaborator Author

aaronc commented Oct 25, 2019

Note support for this is already in the go crypto library as Zaki mentioned: https://golang.org/src/crypto/elliptic/elliptic.go?s=11372:11389#L368

@aaronc aaronc self-assigned this Feb 25, 2020
@aaronc aaronc modified the milestones: Hudson, Spree Feb 25, 2020
@aaronc aaronc removed their assignment Feb 25, 2020
@aaronc
Copy link
Collaborator Author

aaronc commented Feb 25, 2020

@sahith-narahari is this something you could work on? Let's discuss.

@sahith-narahari
Copy link

We shall proceed by implementing pubkey interface for nist p-256. Future steps would be to figure a way to get address from pubkey.
To be discussed is how we can get this implementation for encoding either using protobuf directly or amino.

Useful links

https://golang.org/pkg/crypto/elliptic/#P256
https://golang.org/pkg/crypto/ecdsa/

@clevinson
Copy link

@aaronc please add me to the key mgmt group so I can track this ticket in codetree.

@clevinson
Copy link

@sahith-narahari can you tag @aaronc as a reviewer in a WIP PR so we can take a look at this?

@sahith-narahari
Copy link

Sure @clevinson , will raise a draft PR and tag

@sahith-narahari
Copy link

cosmos#5878 @aaronc can you take a lot at this, I'm stuck at creating public from secp256r1.
Also which random generator can I use for creating sign bytes

@aaronc
Copy link
Collaborator Author

aaronc commented Mar 31, 2020

@sahith-narahari where do you need a random generator?

@clevinson clevinson modified the milestones: Elbe, Himalaya Apr 2, 2020
@robert-zaremba
Copy link

Is this task still on? we are doing it in SDK

@aaronc aaronc closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants