clientv3: fix sync base #5883
Merged
clientv3: fix sync base #5883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westhood
force-pushed
the
master
branch
2 times, most recently
from
610d947 to
720406e
Compare
I am not sure I can understand this. Why should the prefix change per batch? |
| ctx := context.TODO() | ||
|
|
||
| for i := 0; i < 2000; i++ { | ||
| if _, err := cli.Put(ctx, fmt.Sprintf("test%d", i), "test"); err != nil { |
There was a problem hiding this comment.
this test does not work without this patch?
| ctx := context.TODO() | ||
|
|
||
| for i := 0; i < 2000; i++ { | ||
| if _, err := cli.Put(ctx, fmt.Sprintf("test%d", i), "test"); err != nil { |
There was a problem hiding this comment.
probably we need to spin up a bunch of go-routines (50?) to finish the put. Sync put would be slow, each would require a fsync (>10ms on hdd).
It is not correct to use WithPrefix. Range end will change in every internal batch.
|
@westhood Thanks. lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not correct to use WithPrefix. Range end will change in every
batch.