Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests for full feature matrix #1182

Closed
jptosso opened this issue Oct 28, 2024 · 1 comment
Closed

Regression tests for full feature matrix #1182

jptosso opened this issue Oct 28, 2024 · 1 comment

Comments

@jptosso
Copy link
Member

jptosso commented Oct 28, 2024

Right now, we are just testing regression for memoize. We should programmatically build tests for each feature flag set permutation or build tag.
Quoting our build tags from README:

coraza.disabled_operators.* - excludes the specified operator from compilation. Particularly useful if overriding the operator with plugins.RegisterOperator to reduce binary size / startup overhead.
coraza.rule.multiphase_valuation - enables evaluation of rule variables in the phases that they are ready, not only the phase the rule is defined for.
memoize_builders - enables memoization of builders for regex and aho-corasick dictionaries to reduce memory consumption in deployments that launch several coraza instances. For more context check corazawaf/coraza-caddy#76
no_fs_access - indicates that the target environment has no access to FS in order to not leverage OS' filesystem related functionality e.g. file body buffers.
coraza.rule.case_sensitive_args_keys - enables case-sensitive matching for ARGS keys, aligning Coraza behavior with RFC 3986 specification. It will be enabled by default in the next major version.

We should consider tests for each permutation of build tags.

@M4tteoP
Copy link
Member

M4tteoP commented Nov 13, 2024

Completed via #1214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants