fix(bump): transmit tag prefix argument to conventionalRecommendedBump #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Neonox31 thanks for the patch 👍 will try to land soon. |
|
Hello, any news on it ? |
jbottigliero
approved these changes
Jul 24, 2019
|
Hey @Neonox31 – this change looks good to me and I've added this to what I'd like to see land in the next published release. I'm working on coordinating the release with the rest of the conventional-changelog org now... but I'm hoping we can land this before the end of the month! Thanks for understanding and your contribution! |
|
OK thanks ! |
|
@Neonox31 thank you for the contribution 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
prefixTagis never transmitted toconventionalRecommendedBumpparameters.In my case, I have a monorepo with several prefixed tags and
standard-versionwould always bump to major because of using wrong "from" tag.