Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Display only one, correct default for --preset flag #377

Merged
merged 1 commit into from
Jun 7, 2019
Merged

fix(cli): Display only one, correct default for --preset flag #377

merged 1 commit into from
Jun 7, 2019

Conversation

pioluk
Copy link
Contributor

@pioluk pioluk commented Jun 6, 2019

Previously --help would print both "angular" and "conventionalcommits" as defaults for --preset, which was confusing.

$ standard-version --help
Before:

  --preset             Commit message guideline preset (default: angular)
                                                        [string] [default:"conventionalcommits"]

After:

  --preset             Commit message guideline preset  [string] [default: "conventionalcommits"]

Previously --help would print both "angular" and "conventionalcommits" as defaults for --preset, which was confusing.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1eef66a on pioluk:fix/display-correct-default-for-preset into 3aaf72e on conventional-changelog:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1eef66a on pioluk:fix/display-correct-default-for-preset into 3aaf72e on conventional-changelog:master.

@bcoe bcoe merged commit d17fc81 into conventional-changelog:master Jun 7, 2019
@bcoe
Copy link
Member

bcoe commented Jun 7, 2019

@pioluk thanks for the contribution 👍

@pioluk pioluk deleted the fix/display-correct-default-for-preset branch June 7, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants