-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update commit msg for when using commitAll #320
fix: update commit msg for when using commitAll #320
Conversation
The commit message now shows that all staged files are committed too.
I'm fixing the failures. Just noted the local tests too, so I'll check them and update this! |
I've updated this and did now pass local tests. Would an additional test for this be necessary? If so, under which category should this be |
1 similar comment
Yes please :) |
@stevemao I've added the tests under the cli
...
✓ does not display `all staged files` without the --commit-all flag (3501ms)
✓ does display `all staged files` when the --commit-all flag is passed (3708ms)
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vidavidorra could you share what the full console output ends up looking like? It's hard for me to gauge if it looks pretty, based just on the assertions. |
@bcoe The console output now looks like this. Note that I'm executing standard-version twice, see #315 for the $ npm run release -- --dry-run
> [email protected] release /home/jdebruijn/projects/tools
> standard-version --skip.commit --skip.tag "--dry-run"
✔ bumping version in package.json from 0.2.0 to 0.2.1
✔ bumping version in package-lock.json from 0.2.0 to 0.2.1
✔ Running lifecycle script "postbump"
ℹ - execute command: "npm run prettier:package"
✔ outputting changes to CHANGELOG.md
---
<a name="0.2.1"></a>
## [0.2.1](https://github.com/vidavidorra/tools/compare/v0.2.0...v0.2.1) (2019-04-04)
### Bug Fixes
* npm moderatte severity vulnerabilities ([0ae5d02](https://github.com/vidavidorra/tools/commit/0ae5d02))
---
✔ Running lifecycle script "postchangelog"
ℹ - execute command: "npm run prettier:changelog" $ npm run release:ok -- --dry-run
> [email protected] release:ok /home/jdebruijn/projects/tools
> standard-version --sign --commit-all --skip.bump --skip.changelog "--dry-run"
✔ Running lifecycle script "precommit"
ℹ - execute command: "git add CHANGELOG.md package*.json"
✔ committing CHANGELOG.md and all staged files
✔ tagging release v0.2.0
ℹ Run `git push --follow-tags origin master && npm publish` to publish
|
The commit message now shows that all staged files are committed too.