Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli application accept path option #279

Conversation

aldoreno
Copy link
Contributor

@aldoreno aldoreno commented Nov 22, 2018

Path option will be passed down to:

  1. conventional-recommended-bump to produce correct version
  2. conventional-changelog to produce correct changelog

Specifically it will be used by git-raw-commits package.

@aldoreno aldoreno changed the title CLI application now accept path option CLI application accept path option Nov 22, 2018
@aldoreno aldoreno changed the title CLI application accept path option [WIP] CLI application accept path option Nov 22, 2018
@coveralls
Copy link

coveralls commented Nov 22, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 948ba86 on aldoreno:feat/cli-accept-git-raw-commits-options into 844cde6 on conventional-changelog:master.

@aldoreno aldoreno changed the title [WIP] CLI application accept path option CLI application accept path option Nov 22, 2018
@aldoreno aldoreno changed the title CLI application accept path option feat: cli application accept path option Nov 22, 2018
@bcoe bcoe merged commit 69c62cf into conventional-changelog:master Feb 14, 2019
@bcoe
Copy link
Member

bcoe commented Feb 14, 2019

@aldoreno I apologize this took so long to land, always feel free to ping me in slack to help get changes over the finish line faster in the future.

Do me a favor and try out your changes:

npm i [email protected]

@aldoreno
Copy link
Contributor Author

aldoreno commented Feb 14, 2019 via email

@aldoreno aldoreno deleted the feat/cli-accept-git-raw-commits-options branch February 15, 2019 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants