-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for npm-shrinkwrap.json
#185
Conversation
Could you also add support for |
@stevemao the CLI team at npm tells me that you shouldn't publish the package-lock.json to the registry; and it looks like I say we land this feature, and I'll talk to my coworkers Monday to see if we would want to increment the version in |
Did you mean to publish to the npm registry? The whole workflow we are dealing here doesn't include this step. We only checkin the changes to git. Also I believe
I was looking at npm/npm@d654a8e
Sounds good. I honestly don't know if |
@stevemao I'll follow up tomorrow; and create an issue if the CLI team thinks we should bump the version in |
You should. |
@noreiller, zkat literally wrote the book on this -- don't suppose I could convince you to send a follow up pull request. |
fwiw, y'all should treat |
@noreiller your changes are currently available in
also, would happily accept a follow on pull-request with support for |
Hi @bcoe, I just ran successful tests with |
PR #190 😄 |
@noreiller awesome 👍 |
Hi, I use your module since a few weeks, and as I missed this little feature, here it is.
By the way, I fixed the bower test since it didn't check the
bower.json
file. 😄Thank for your great work.
Aurélien