feat: make tagPrefix configurable #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
requested changes
Nov 26, 2016
| .option('tag-prefix', { | ||
| alias: 't', | ||
| describe: 'Set a custom prefix for the git tag to be created', | ||
| type: 'boolean', |
There was a problem hiding this comment.
If you switch the type to string rather than boolean I believe the tests should start passing.
There was a problem hiding this comment.
Thanks for feedback! I didn't notice the test failed, sorry about that. Corrected now, but I see merge conflict. I'll see if I can rebase.
1 similar comment
bcoe
approved these changes
Nov 27, 2016
|
@niieani I've landed your changes in an upcoming release, would love an extra set of eyes on it. To test it out:
👍 |
|
Many thanks! I'll have a go at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Aurelia we don't use any tag prefixes, our tags are just
1.0, thus we couldn't usestandard-versionas is. Right nowstandard-versionhas a hardcodedvprefix for all the git tags for releases, i.e.v1.0,v1.1. This change makes it configurable so you can have no prefix or a custom prefix if you wish. I left the defaultvprefix, so this is a non-breaking change.