Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check private field in package.json(#102) #103

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Sep 12, 2016

Fix #102. It should not suggest npm publish if the package.json has private: true.

@coveralls
Copy link

coveralls commented Sep 12, 2016

Coverage Status

Coverage increased (+0.1%) to 95.062% when pulling 2d4de35 on watilde:patch/check-private into 1ad772a on conventional-changelog:master.

It should not suggest `npm publish` if the package.json
has `private: true`.
@watilde watilde force-pushed the patch/check-private branch from 2d4de35 to ee5bf76 Compare September 12, 2016 19:04
@coveralls
Copy link

coveralls commented Sep 12, 2016

Coverage Status

Coverage increased (+0.1%) to 95.062% when pulling ee5bf76 on watilde:patch/check-private into 1ad772a on conventional-changelog:master.

@nexdrew
Copy link
Member

nexdrew commented Sep 12, 2016

LGTM, thanks @watilde!

@stevemao stevemao merged commit 2ce4160 into conventional-changelog:master Sep 12, 2016
@watilde watilde deleted the patch/check-private branch September 13, 2016 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants