Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling numcodecs on other architectures #11

Closed
jakirkham opened this issue Dec 13, 2022 · 3 comments · Fixed by #14
Closed

Enabling numcodecs on other architectures #11

jakirkham opened this issue Dec 13, 2022 · 3 comments · Fixed by #14

Comments

@jakirkham
Copy link
Member

It appears that numcodecs only gets installed on x86_64 (as seen below). Likely this preceded numcodecs being built on other platforms.

# numcodecs is only packaged for x86-64 - run without those tests on other platformss
- numcodecs # [x86_64]

However in PR ( conda-forge/numcodecs-feedstock#76 ), numcodecs was enabled on other platforms. This has been around for ~1yr now.

Given this, maybe this selector can be dropped?

@mdekstrand
Copy link
Contributor

Thanks! This should also mean I can change binpickle to be a noarch package, at least if I drop Python 3.7 support.

This was referenced Dec 17, 2022
@jakirkham
Copy link
Member Author

As conda-forge has dropped Python 3.7 ( conda-forge/conda-forge-pinning-feedstock#2623 ), it would be reasonable to drop it from this feedstock unless there was some compelling reason to keep it.

@mdekstrand
Copy link
Contributor

@jakirkham thanks! I put a >=3.8 dep in this feedstock and released as noarch, using numcodecs on all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants