Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider relying on CometBFT's rpc/http client #9

Open
cason opened this issue Jan 11, 2024 · 0 comments
Open

Consider relying on CometBFT's rpc/http client #9

cason opened this issue Jan 11, 2024 · 0 comments

Comments

@cason
Copy link

cason commented Jan 11, 2024

I have the impression (close this issue if it is not the case) that this tool implements by itself the interaction via RPC with Comet nodes, to submit load and other functionalities.

We should instead use one of the existing RPC client implementations in Comet. In particular because, in this case, we don't need to maintain another version here.

I think that one of reasons for this local implementation, however, is the fact that CometBFT repo imports this repo, so that importing CometBFT here would cause an import loop. Not sure how easy is to prevent this loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant