Allow optional request headers #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows callers to add optional request headers on a per-call basis. For example, to supply an `HttpHeaders.IfNoneMatch` value for [ETag caching](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag) if the Twirp service supports it, like [the `twirp-rails` gem does](https://github.com/collectiveidea/twirp-rails#basic-caching-with-etagsif-none-match-headers). Another optional use might be sending an `Idempotency-Key` header for idempotent requests.
danielmorrison
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows callers to add optional request headers on a per-call basis.
For example, to supply an
HttpHeaders.IfNoneMatchvalue for ETag caching if the Twirp service supports it, like thetwirp-railsgem does. Another optional use might be sending anIdempotency-Keyheader for idempotent requests.Example usage of the generated code might look something like: