Add additional target platforms #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since our runtime depends on [PBandK](https://raw.githubusercontent.com/streem/pbandk) and [Ktor Client](https://github.com/ktorio/ktor), without any specific platform-handling code on its own, we can declare support for (and publish the library for) all possible targets at the intersection of those two dependencies and things should just work downstream. Ktor Targets: https://github.com/ktorio/ktor/blob/main/buildSrc/src/main/kotlin/NativeUtils.kt PBandK Runtime Targets: https://github.com/streem/pbandk/blob/master/runtime/build.gradle.kts Note that ktor-client-core 2.3.12 does not support `wasmJs`.
`Name contains illegal chars that cannot appear in JavaScript identifier.` I thought about using the `@JsName` annotation here to just rename the test method in JavaScript, but that potentially duplicated the test name. Easier to just replace spaced with underscores, and then remove the backtick escapes.
darronschall
force-pushed
the
add-additional-targets
branch
from
6a39709 to
c2314ef
Compare
manlycode
reviewed
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
Since our runtime depends on PBandK and Ktor Client, without any specific platform-handling code on its own, we can declare support for (and publish the library for) all possible targets at the intersection of those two dependencies and things should just work downstream.
Ktor Targets: https://github.com/ktorio/ktor/blob/main/buildSrc/src/main/kotlin/NativeUtils.kt
PBandK Runtime Targets: https://github.com/streem/pbandk/blob/master/runtime/build.gradle.kts
Note that ktor-client-core 2.3.12 does not support
wasmJs.