-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the registry.xml to use plone.base.interfaces.resources.IBundleRegistry #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general but please add a note in CHANGES.rst as we do not use towncrier here.
I added a news item as it is suggested in the CHANGES.rst, I hope this is what you suggested also @petschki. |
oh, sorry your're right ... we do use towncrier actually. perfect 👍🏼 I'll use your PR to do some housekeeping too if you don't mind (JS dependency updates) then I'll merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, you've forked the repo. So lets merge this and do the housekeeping separately.
It would be better to create a PR directly on collective
so that other users can change things too ... otherwise you would have to grant access to your repo... but that's for the next one 😉
I see your point, I will keep this in mind for the next time:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, two more things:
- would you please change the interface location also in the uninstall profile ... just the same like in default ...
- we need an upgrade step to version
6
with the new registry interface ... see theupgrades
folder. basically the same like its done in5
without the removals.
…es.resources.IBundleRegistry
Changed the uninstall profile as well and also included version 6 to the upgrades as requested. |
Thanks! you can remove my access from your repo now ... |
Related to Issue 193
Changed the registry.xml to use "plone.base.interfaces.resources.IBundleRegistry" instead of "Products.CMFPlone.interfaces.IBundleRegistry"